Skip to main content

Avoid core::mem::forget usage

Description​

The core::mem::forget function usage is a bad practice.

Exploit Scenario​

Consider the following Soroban contract:

   pub fn forget_something(n: WithoutCopy) -> u64 {
        core::mem::forget(n);
        0
    }

The problem arises from the use of the core::mem::forget function. This function is used to forget about a value without running its destructor. This is a bad practice because it can lead to memory leaks, resource leaks and logic errors.

The vulnerable code example can be found here.

Remediation​

Use the pattern let _ = n; or the .drop() method instead of core::mem::forget(n);.

References​